PHP Classes

Bugs

Recommend this page to a friend!

      Eyesis Data Grid Control  >  All threads  >  Bugs  >  (Un) Subscribe thread alerts  
Subject:Bugs
Summary:PHP Notice: Undefined Notices & a typo
Messages:3
Author:Mike Banks
Date:2008-11-29 21:02:16
Update:2008-12-02 02:30:50
 

  1. Bugs   Reply   Report abuse  
Picture of Mike Banks Mike Banks - 2008-11-29 21:02:16
class.eyedatagrid.inc.php
Typo line 796 changed $crtieria to $criteria

Many "PHP Notice: Undefined ..." being generated from your example pages. set Error reporting to E_ALL to see them.
I've been simply adding some 'isset' conditions to quell them such as on lines 96,97,98

$page = (isset($_GET['page']))? (int) $_GET['page'] : 0; // Page number
$order = (isset($_GET['order']))? $_GET['order'] : ''; // Order clause
$filter = (isset($_GET['filter']))? $_GET['filter'] : ''; // Filter clause

Also I snagged your filter.gif image off your site as it was missing from the included images.

Regardless of the above I very much appreciate your hard work on this and will be using it.
Best Regards,
Doug


  2. Re: Bugs   Reply   Report abuse  
Picture of Mike Frank Mike Frank - 2008-12-01 19:21:29 - In reply to message 1 from Mike Banks
-Fixed line 796 criteria misspelled
-Added suggested code
-Added filter.gif image

Notices provided by E_ALL are not a concern.

  3. Re: Bugs   Reply   Report abuse  
Picture of Mike Banks Mike Banks - 2008-12-02 02:30:50 - In reply to message 2 from Mike Frank
If you had turned on E_ALL you would have caught the typo.
For a production environment no error notices are a good thing.

Common Style Mistakes, Part 1 | O'Reilly Media
onlamp.com/pub/a/php/2003/05/29/php ...